NickJavaDev88 commented on PR #10986:
URL: https://github.com/apache/ozone/pull/10986#issuecomment-5250255039
Thanks for the review, @echonesis — both addressed in 3b89d3677 :
- Replaced the hard-coded 404 with HttpURLConnection.HTTP_NOT_FOUND.
- Every assertThrows(S3Exception.class, ...) in the new lifecycle tests
now captures the exception and asserts both statusCode() and
awsErrorDetails().errorCode() against the matching S3ErrorTable constant,
instead of just checking that something was thrown.
Verified locally: all 4 new lifecycle tests
(testS3LifecycleConfigurationCreateSuccessfully, CreationFailed, Delete, Get)
pass against a real MiniOzoneCluster in both AbstractS3SDKV1Tests and
AbstractS3SDKV2Tests.
CI is running on the latest commit:
https://github.com/NickJavaDev88/ozone/actions/runs/31464196500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
