chungen0126 commented on code in PR #10930: URL: https://github.com/apache/ozone/pull/10930#discussion_r3756438285
########## hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestObjectAttributesGet.java: ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.s3.endpoint; + +import static java.net.HttpURLConnection.HTTP_OK; +import static org.apache.hadoop.ozone.s3.S3GatewayConfigKeys.OZONE_S3G_FSO_DIRECTORY_CREATION_ENABLED; +import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.assertErrorResponse; +import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.assertSucceeds; +import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.getObjectAttributes; +import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.put; +import static org.apache.hadoop.ozone.s3.exception.S3ErrorTable.INVALID_ARGUMENT; +import static org.apache.hadoop.ozone.s3.exception.S3ErrorTable.NO_SUCH_BUCKET; +import static org.apache.hadoop.ozone.s3.exception.S3ErrorTable.NO_SUCH_KEY; +import static org.apache.hadoop.ozone.s3.util.S3Consts.X_AMZ_CONTENT_SHA256; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; + +import java.io.IOException; +import javax.ws.rs.core.HttpHeaders; +import javax.ws.rs.core.Response; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.client.OzoneBucket; +import org.apache.hadoop.ozone.client.OzoneClient; +import org.apache.hadoop.ozone.client.OzoneClientStub; +import org.apache.hadoop.ozone.s3.exception.OS3Exception; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; + +/** + * Tests for GetObjectAttributes. + */ +public class TestObjectAttributesGet { + + private static final String CONTENT = "0123456789"; + private static final String BUCKET_NAME = "b1"; + private static final String KEY_NAME = "key1"; + private ObjectEndpoint rest; + private OzoneBucket bucket; + + @BeforeEach + public void init() throws Exception { + OzoneClient client = new OzoneClientStub(); + client.getObjectStore().createS3Bucket(BUCKET_NAME); + bucket = client.getObjectStore().getS3Bucket(BUCKET_NAME); + + HttpHeaders headers = Mockito.mock(HttpHeaders.class); + Mockito.when(headers.getHeaderString(X_AMZ_CONTENT_SHA256)) + .thenReturn("UNSIGNED-PAYLOAD"); + + rest = EndpointBuilder.newObjectEndpointBuilder() + .setClient(client) + .setHeaders(headers) + .build(); + } + + @Test + public void testGetObjectAttributesAllSupportedFields() throws IOException, OS3Exception { + assertSucceeds(() -> put(rest, BUCKET_NAME, KEY_NAME, CONTENT)); + + Response response = getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, + "ETag,ObjectSize,StorageClass"); + + assertEquals(HTTP_OK, response.getStatus()); + assertNotNull(response.getHeaderString(HttpHeaders.LAST_MODIFIED)); + + GetObjectAttributesResponse attributes = (GetObjectAttributesResponse) response.getEntity(); + assertNotNull(attributes); + assertNotNull(attributes.getETag()); + assertFalse(attributes.getETag().startsWith("\"")); + assertEquals(CONTENT.length(), attributes.getObjectSize().longValue()); + assertEquals("STANDARD", attributes.getStorageClass()); + assertNull(attributes.getObjectParts()); + } + + @Test + public void testGetObjectAttributesEtagOnly() throws IOException, OS3Exception { + assertSucceeds(() -> put(rest, BUCKET_NAME, KEY_NAME, CONTENT)); + + Response response = getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, "ETag"); + + assertEquals(HTTP_OK, response.getStatus()); + GetObjectAttributesResponse attributes = (GetObjectAttributesResponse) response.getEntity(); + assertNotNull(attributes.getETag()); + assertNull(attributes.getObjectSize()); + assertNull(attributes.getStorageClass()); + } + + @Test + public void testGetObjectAttributesChecksumRequestedButOmitted() throws IOException, OS3Exception { + assertSucceeds(() -> put(rest, BUCKET_NAME, KEY_NAME, CONTENT)); + + Response response = getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, "Checksum,ETag"); + + assertEquals(HTTP_OK, response.getStatus()); + GetObjectAttributesResponse attributes = (GetObjectAttributesResponse) response.getEntity(); + assertNotNull(attributes.getETag()); + } + + @Test + public void testGetObjectAttributesMissingHeader() { + assertErrorResponse(INVALID_ARGUMENT, + () -> getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, null)); + } + + @Test + public void testGetObjectAttributesInvalidAttribute() { + assertErrorResponse(INVALID_ARGUMENT, + () -> getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, "NotAValidAttribute")); + } + + @Test + public void testGetObjectAttributesNoKeyFound() { + assertErrorResponse(NO_SUCH_KEY, + () -> getObjectAttributes(rest, BUCKET_NAME, "nonexistent", "ETag")); + } + + @Test + public void testGetObjectAttributesNoBucketFound() { + assertErrorResponse(NO_SUCH_BUCKET, + () -> getObjectAttributes(rest, "nonexistent", "any", "ETag")); + } + + @Test + public void testGetObjectAttributesNonMultipartObjectHasNoParts() throws IOException, OS3Exception { + assertSucceeds(() -> put(rest, BUCKET_NAME, KEY_NAME, CONTENT)); + + Response response = getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, "ObjectParts"); + + assertEquals(HTTP_OK, response.getStatus()); + GetObjectAttributesResponse attributes = (GetObjectAttributesResponse) response.getEntity(); + assertNull(attributes.getObjectParts()); + } + + @Test + public void testWhenKeyIsDirectoryAndKeyPathDoesNotEndWithASlash() throws Exception { + final String keyPath = "keyDir"; + OzoneConfiguration config = new OzoneConfiguration(); + config.set(OZONE_S3G_FSO_DIRECTORY_CREATION_ENABLED, "true"); + rest.setOzoneConfiguration(config); + bucket.createDirectory(keyPath); + + assertErrorResponse(NO_SUCH_KEY, + () -> getObjectAttributes(rest, BUCKET_NAME, keyPath, "ETag")); + } + + @Test + public void testWhenKeyIsDirectoryAndKeyPathEndsWithASlash() throws Exception { + final String keyPath = "keyDir/"; + OzoneConfiguration config = new OzoneConfiguration(); + config.set(OZONE_S3G_FSO_DIRECTORY_CREATION_ENABLED, "true"); Review Comment: ```suggestion config.setBoolean(OZONE_S3G_FSO_DIRECTORY_CREATION_ENABLED, true); ``` ########## hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestObjectAttributesGet.java: ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.s3.endpoint; + +import static java.net.HttpURLConnection.HTTP_OK; +import static org.apache.hadoop.ozone.s3.S3GatewayConfigKeys.OZONE_S3G_FSO_DIRECTORY_CREATION_ENABLED; +import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.assertErrorResponse; +import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.assertSucceeds; +import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.getObjectAttributes; +import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.put; +import static org.apache.hadoop.ozone.s3.exception.S3ErrorTable.INVALID_ARGUMENT; +import static org.apache.hadoop.ozone.s3.exception.S3ErrorTable.NO_SUCH_BUCKET; +import static org.apache.hadoop.ozone.s3.exception.S3ErrorTable.NO_SUCH_KEY; +import static org.apache.hadoop.ozone.s3.util.S3Consts.X_AMZ_CONTENT_SHA256; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; + +import java.io.IOException; +import javax.ws.rs.core.HttpHeaders; +import javax.ws.rs.core.Response; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.client.OzoneBucket; +import org.apache.hadoop.ozone.client.OzoneClient; +import org.apache.hadoop.ozone.client.OzoneClientStub; +import org.apache.hadoop.ozone.s3.exception.OS3Exception; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; + +/** + * Tests for GetObjectAttributes. + */ +public class TestObjectAttributesGet { + + private static final String CONTENT = "0123456789"; + private static final String BUCKET_NAME = "b1"; + private static final String KEY_NAME = "key1"; + private ObjectEndpoint rest; + private OzoneBucket bucket; + + @BeforeEach + public void init() throws Exception { + OzoneClient client = new OzoneClientStub(); + client.getObjectStore().createS3Bucket(BUCKET_NAME); + bucket = client.getObjectStore().getS3Bucket(BUCKET_NAME); + + HttpHeaders headers = Mockito.mock(HttpHeaders.class); + Mockito.when(headers.getHeaderString(X_AMZ_CONTENT_SHA256)) + .thenReturn("UNSIGNED-PAYLOAD"); + + rest = EndpointBuilder.newObjectEndpointBuilder() + .setClient(client) + .setHeaders(headers) + .build(); + } + + @Test + public void testGetObjectAttributesAllSupportedFields() throws IOException, OS3Exception { + assertSucceeds(() -> put(rest, BUCKET_NAME, KEY_NAME, CONTENT)); + + Response response = getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, + "ETag,ObjectSize,StorageClass"); + + assertEquals(HTTP_OK, response.getStatus()); + assertNotNull(response.getHeaderString(HttpHeaders.LAST_MODIFIED)); + + GetObjectAttributesResponse attributes = (GetObjectAttributesResponse) response.getEntity(); + assertNotNull(attributes); + assertNotNull(attributes.getETag()); + assertFalse(attributes.getETag().startsWith("\"")); + assertEquals(CONTENT.length(), attributes.getObjectSize().longValue()); + assertEquals("STANDARD", attributes.getStorageClass()); + assertNull(attributes.getObjectParts()); + } + + @Test + public void testGetObjectAttributesEtagOnly() throws IOException, OS3Exception { + assertSucceeds(() -> put(rest, BUCKET_NAME, KEY_NAME, CONTENT)); + + Response response = getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, "ETag"); + + assertEquals(HTTP_OK, response.getStatus()); + GetObjectAttributesResponse attributes = (GetObjectAttributesResponse) response.getEntity(); + assertNotNull(attributes.getETag()); + assertNull(attributes.getObjectSize()); + assertNull(attributes.getStorageClass()); + } + + @Test + public void testGetObjectAttributesChecksumRequestedButOmitted() throws IOException, OS3Exception { + assertSucceeds(() -> put(rest, BUCKET_NAME, KEY_NAME, CONTENT)); + + Response response = getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, "Checksum,ETag"); + + assertEquals(HTTP_OK, response.getStatus()); + GetObjectAttributesResponse attributes = (GetObjectAttributesResponse) response.getEntity(); + assertNotNull(attributes.getETag()); + } + + @Test + public void testGetObjectAttributesMissingHeader() { + assertErrorResponse(INVALID_ARGUMENT, + () -> getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, null)); + } + + @Test + public void testGetObjectAttributesInvalidAttribute() { + assertErrorResponse(INVALID_ARGUMENT, + () -> getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, "NotAValidAttribute")); + } + + @Test + public void testGetObjectAttributesNoKeyFound() { + assertErrorResponse(NO_SUCH_KEY, + () -> getObjectAttributes(rest, BUCKET_NAME, "nonexistent", "ETag")); + } + + @Test + public void testGetObjectAttributesNoBucketFound() { + assertErrorResponse(NO_SUCH_BUCKET, + () -> getObjectAttributes(rest, "nonexistent", "any", "ETag")); + } + + @Test + public void testGetObjectAttributesNonMultipartObjectHasNoParts() throws IOException, OS3Exception { + assertSucceeds(() -> put(rest, BUCKET_NAME, KEY_NAME, CONTENT)); + + Response response = getObjectAttributes(rest, BUCKET_NAME, KEY_NAME, "ObjectParts"); + + assertEquals(HTTP_OK, response.getStatus()); + GetObjectAttributesResponse attributes = (GetObjectAttributesResponse) response.getEntity(); + assertNull(attributes.getObjectParts()); + } + + @Test + public void testWhenKeyIsDirectoryAndKeyPathDoesNotEndWithASlash() throws Exception { + final String keyPath = "keyDir"; + OzoneConfiguration config = new OzoneConfiguration(); + config.set(OZONE_S3G_FSO_DIRECTORY_CREATION_ENABLED, "true"); Review Comment: ```suggestion config.setBoolean(OZONE_S3G_FSO_DIRECTORY_CREATION_ENABLED, true); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
