smengcl opened a new pull request, #11010:
URL: https://github.com/apache/ozone/pull/11010
Generated-by: Claude Code (Opus 4.8)
## What changes were proposed in this pull request?
`TestReconAndAdminContainerCLI#testNodesInDecommissionOrMaintenance`
(decommission parameterization) intermittently times out at
`OzoneTestHelper.waitForReplicaCount` while waiting for a
decommission-triggered replica copy (3 to 4 for the first node, 4 to 5 for the
second) to be reflected in SCM.
The shared `waitForReplicaCount` helper used a fixed 30s budget for all of
its callers. HDDS-10582 only reduced the poll interval (1000ms to 200ms) and
kept the 30s total, so under a loaded CI runner the replica copy is not always
observed within the budget and the test flakes.
This adds a 4-arg `waitForReplicaCount` overload that accepts a timeout,
leaving the existing 3-arg method delegating with the same 30s default (no
behavior change for the other callers). The decommission/maintenance
replica-copy waits in `TestReconAndAdminContainerCLI` now use a 120s budget,
matching the larger timeouts already adopted elsewhere for this class of
replication waits. The test stays tagged `@Flaky("HDDS-11128")` because a
larger timeout cannot prove non-flakiness.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11128
## How was this patch tested?
Existing test, no new coverage added (timeout-only change to a flaky
integration test).
- `mvn -pl :ozone-integration-test test-compile` and `mvn -pl
:ozone-integration-test-recon test-compile`: both compile.
- `checkstyle.sh` on both changed modules: no violations.
This is a timeout increase, so a single green run cannot prove the flake is
gone; the change only widens the window in which the decommission-triggered
replica copy must be observed, and leaves the `@Flaky` tag in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]