ChenSammi commented on code in PR #9902: URL: https://github.com/apache/ozone/pull/9902#discussion_r3776112118
########## hadoop-ozone/dist/src/main/smoketest/security/ozone-secure-sts.resource: ########## @@ -0,0 +1,320 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +*** Settings *** +Library OperatingSystem +Library String +Library BuiltIn +Library DateTime +Library Collections +Resource ../commonlib.robot +Resource ../s3/commonawslib.robot + +*** Variables *** +${RANGER_ENDPOINT_URL} ${EMPTY} +${STS_ENDPOINT_URL} http://s3g:9880/sts +${S3G_ENDPOINT_URL} http://s3g:9878 +${ROLE_SESSION_NAME} sts-session-name +${EXPIRED_STS_TOKEN_PROFILE} expired_sts_token +${EXPIRED_STS_TOKEN_MIN_ELAPSED_SECONDS} 902 Review Comment: @fmorg-git , we cannot afford to wait 902 seconds in ozone-secure-sts.robot in Ozone github CI. There are two solutions for this, 1. remove this test case from the robot test, or 2. allow STS token to be expired quickly in test environment. To achieve this, we usually design some specific property for test, like a switch, if the property is turned on, means it's a test environment, then some constriction can be lowed. Or you can first remove the test case in this patch, and open a new follow up JIRA to add back the test case later with solution 2. Apart from this, the rest looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
