navinko commented on PR #10993: URL: https://github.com/apache/ozone/pull/10993#issuecomment-5309738000
> @navinko , thanks for the update! > > Using Map in this case in unnecessary (since get(key) is never called) and inefficient. Let's change them to List; see https://issues.apache.org/jira/secure/attachment/13083934/10993_review.patch Thanks @szetszwo for the review. Updated the changes as per review patch. Switched the safe-mode status flow to List<SafeModeRuleStatusProto> end-to-end and removed the unnecessary map conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
