ivandika3 commented on code in PR #9856:
URL: https://github.com/apache/ozone/pull/9856#discussion_r3793559216
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManager.java:
##########
@@ -172,15 +172,15 @@ void
updateContainerStateWithSequenceId(HddsProtos.ContainerID id,
/**
- * Bypasses the container state machine to change a container's state from
DELETING or DELETED to CLOSED. This API was
- * introduced to fix a bug (HDDS-11136), and should be used with care
otherwise.
+ * Bypasses the container state machine to change a container's state from
DELETING/DELETED to CLOSED/QUASI_CLOSED.
*
- * @see <a
href="https://issues.apache.org/jira/browse/HDDS-11136";>HDDS-11136</a>
* @param id id of the container to transition
+ * @param targetState the target state (must be CLOSED or QUASI_CLOSED)
* @throws IOException
*/
@Replicate
- void transitionDeletingOrDeletedToClosedState(HddsProtos.ContainerID id)
throws IOException;
+ void transitionDeletingOrDeletedToTargetState(HddsProtos.ContainerID id,
LifeCycleState targetState)
+ throws IOException;
Review Comment:
Note that changing Replicate might crash SCM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
