sreejasahithi commented on code in PR #10938:
URL: https://github.com/apache/ozone/pull/10938#discussion_r3793941773
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -836,7 +840,7 @@ private void checkIterationMoveResults() {
* @return number of moves that did not complete (timed out) and were
* cancelled.
*/
- private long cancelMovesThatExceedTimeoutDuration() {
+ private long cancelMovesThatExceedTimeoutDuration(String reason) {
Review Comment:
I was currently sending
ContainerMoveFailureReason.ITERATION_MOVE_TIMEOUT.name() as a param to
cancelMovesThatExceedTimeoutDuration from the call site that is
checkIterationMoveResults when a TimeoutException happens.
But we can change this and have
ContainerMoveFailureReason.ITERATION_MOVE_TIMEOUT.name() directly recorded as
you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
