Gargi-jais11 commented on PR #11034: URL: https://github.com/apache/ozone/pull/11034#issuecomment-5316271259
> Thanks @ChenSammi for the patch. > > I think there are two more pure admin ops and should use `isAdminAuthorizationEnabled()` (like OMCancelPrepareRequest), not getAclsEnabled(): > > * OMLifecycleConfigurationSetRequest.java, > * OMLifecycleConfigurationDeleteRequest.java > > Could u please check these two classes whether they are pure admin or need acl checks? > > 1. https://github.com/apache/ozone/blob/a552e060433082fe524ed07067e027c2795ba142/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/lifecycle/OMLifecycleConfigurationSetRequest.java#L93-L95 > 2. https://github.com/apache/ozone/blob/a552e060433082fe524ed07067e027c2795ba142/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/lifecycle/OMLifecycleConfigurationDeleteRequest.java#L80-L82 My bad. I misinterpreted the working of this class. Please ignore the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
