yandrey321 commented on code in PR #11041:
URL: https://github.com/apache/ozone/pull/11041#discussion_r3800113755
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerSelectionCriteria.java:
##########
@@ -247,7 +247,7 @@ private boolean isContainerHealthyForMove(ContainerInfo
container, Set<Container
ContainerHealthResult.HealthState state =
replicationManager.getContainerReplicationHealth(container,
replicas).getHealthState();
if (state != ContainerHealthResult.HealthState.HEALTHY) {
- LOG.debug("Excluding container {} with replicas {} as its health is
{}.", container, replicas, state);
+ LOG.info("Excluding container {} with replicas {} as its health is {}.",
container, replicas, state);
Review Comment:
I'd rather dump list of excluded containers instead of spamming logs with
these messages. Also I'd consider limiting amount of entries that are getting
logged to 50 or less + number of entries in exclude list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
