ivandika3 commented on code in PR #11035: URL: https://github.com/apache/ozone/pull/11035#discussion_r3800218494
########## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java: ########## @@ -55,13 +54,6 @@ */ @InterfaceStability.Unstable Review Comment: Should we add a `InterfaceAudience.Private` here? We can start adding `InterfaceAudience` and `InterfaceStability` to these classes to clarify the interface contracts. @szetszwo what do you think? ########## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java: ########## @@ -55,13 +54,6 @@ */ @InterfaceStability.Unstable Review Comment: Should we add a `InterfaceAudience.Private` here? We can start adding `InterfaceAudience` and `InterfaceStability` to these classes to clarify the interface contracts. @szetszwo @echonesis what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
