echonesis commented on PR #11013: URL: https://github.com/apache/ozone/pull/11013#issuecomment-5326445943
> Overall it looks good. One small thing. It would be better to move service shutdown in @AfterEach. That would prevent this problem in future tests (if someone miss the shutdown) Thanks for the suggestion. I moved the service shutdown to @AfterEach and registered the service when it is created by the test helper. This ensures the asynchronous deletion tasks finish before the container cache is cleaned up, including when a test fails or a future test misses an explicit shutdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
