[
https://issues.apache.org/jira/browse/HDDS-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18105676#comment-18105676
]
Tsz-wo Sze commented on HDDS-16192:
-----------------------------------
As a summary, we could start by testing if we could remove KerberosInfo and
versionID from StorageContainerLocationProtocol. Although I am pretty sure
about it, we should test it, especially testing compatibility -- make sure
servers with the new code could work with the servers with old code.
{code}
+++
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocol.java
@@ -54,17 +54,7 @@
* ContainerLocationProtocol is used by an HDFS node to find the set of nodes
* that currently host a container.
*/
-@KerberosInfo(serverPrincipal = ScmConfig.ConfigStrings
- .HDDS_SCM_KERBEROS_PRINCIPAL_KEY)
public interface StorageContainerLocationProtocol extends Closeable {
-
- // Accessed and checked via reflection in Hadoop RPC - changing it is
incompatible
- @SuppressWarnings({"checkstyle:ConstantName", "unused"})
- /**
- * Version 1: Initial version.
- */
- long versionID = 1L;
-
/**
* Admin command should take effect on all SCM instance.
*/
{code}
> Refactor o.a.h.hdds.scm.protocol
> ---------------------------------
>
> Key: HDDS-16192
> URL: https://issues.apache.org/jira/browse/HDDS-16192
> Project: Apache Ozone
> Issue Type: Improvement
> Components: SCM
> Reporter: Tsz-wo Sze
> Priority: Major
>
> ||interface||protocol (gRPC service)||
> |StorageContainerLocationProtocol|StorageContainerLocationProtocolService|
> |ScmBlockLocationProtocol|ScmBlockLocationProtocolService|
> The above interfaces in package org.apache.hadoop.hdds.scm.protocol are just
> internal interfaces but not really protocols, in the sense that changing the
> signatures of the methods does NOT change the underlying protocols, where the
> underlying protocols are defined in the corresponding gRPC services.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
