rich7420 opened a new pull request, #11058:
URL: https://github.com/apache/ozone/pull/11058
## What changes were proposed in this pull request?
ContainerKeyMapperHelper.handleKeyReprocess and handlePutOMKeyEvent iterate
getLocationList() for every version group, but the loop body only reads
getContainerID():
for (OmKeyLocationInfoGroup omKeyLocationInfoGroup :
omKeyInfo.getKeyLocationVersions()) {
long keyVersion = omKeyLocationInfoGroup.getVersion();
for (OmKeyLocationInfo omKeyLocationInfo :
omKeyLocationInfoGroup.getLocationList())
{ long containerId = omKeyLocationInfo.getContainerID(); ... }
}
getLocationList() is documented as not O(1); it flatten-copies into a new
List. handleKeyReprocess runs over the entire OM key table during Recon
reprocess (ParallelTableIteratorOperation), so a list is allocated per version
group per key across the whole keyspace.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16212
## How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/32219894034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
