F64116045 commented on PR #10928: URL: https://github.com/apache/ozone/pull/10928#issuecomment-5344148860
Thanks everyone for the guidance. Since the diff became larger after syncing the feature branch and addressing the review comments, I wanted to summarize the current patch to make review easier. The main changes are: - `PendingContainerTracker` now records pending allocations with `StorageType` and counts them per requested storage type. - Container allocation uses the atomic `checkSpaceAndRecordAllocation(...)` flow and passes the `StorageType` derived from the pipeline `StorageTier`. - Pending allocations are removed when container reports confirm the container as present or absent on the datanode. - Following the discussion in apache/ozone#10983, the data-space check was moved from `SCMCommonPlacementPolicy` into `PendingContainerTracker`, exposed through `NodeManager.hasAvailableSpace(...)`. Most of the remaining test changes are mechanical updates for the new method signatures. The main behavioral tests are in: - `TestPendingContainerTracker` - `TestPipelineManagerImpl` - `TestSCMNodeManager` - `TestSCMCommonPlacementPolicy` I ran the targeted SCM tests locally and will keep an eye on CI, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
