fmorg-git commented on PR #11042: URL: https://github.com/apache/ozone/pull/11042#issuecomment-5351109207
> Thanks for splitting this out! @fmorg-git the move itself looks right to me. > > One scope question: the Jira is about the suite split, but this also brings back the expired-token test with the same long wait that #9902 suggested replacing with a test-only fast-expiry switch. The dedicated suite does make that wait parallel rather than blocking misc, so maybe that is enough. Intended tradeoff, or land the split here and do that test separately? > > I also left a few small notes inline. hi @chihsuan @ChenSammi - yes, I added back the expired token test since we need the coverage. Someone (internally) recently reported that expired token wasn't being returned on a particular api and I thought let me run the smoke test to double-check, and it wasn't there. Also, I believe splitting the tests into its own suite helps alleviate the concern about timing. Also, the expired token tests don't meaningfully add much time. It is designed to create a token at the beginning, run through as many tests as possible (which takes close to 15 minutes anyway), then check that the expired token messages are returned. Finally, strangely, I'll respond to @ChenSammi's request below, but it looks like the timing went `down` when the expired token tests were added back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
