smengcl commented on code in PR #11056: URL: https://github.com/apache/ozone/pull/11056#discussion_r3828053910
########## hadoop-ozone/dev-support/checks/errorprone.sh: ########## @@ -0,0 +1,57 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#checks:basic + +set -u -o pipefail + +DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" +cd "$DIR/../../.." || exit 1 + +REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target/errorprone"} +mkdir -p "$REPORT_DIR" + +REPORT_FILE="$REPORT_DIR/summary.txt" + +MAVEN_OPTIONS='-B -fae --no-transfer-progress -Perrorprone -DskipDocs -DskipRecon -DskipShade' + +declare -i rc + +#shellcheck disable=SC2086 +mvn $MAVEN_OPTIONS test-compile "$@" | tee "${REPORT_DIR}/output.log" Review Comment: Should this be `clean test-compile`? If the classes were previously compiled without the `errorprone` profile, Maven considers them up to date and skips javac, so Error Prone does not run. ```suggestion mvn $MAVEN_OPTIONS clean test-compile "$@" | tee "${REPORT_DIR}/output.log" ``` ########## hadoop-ozone/dev-support/checks/errorprone.sh: ########## @@ -0,0 +1,57 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#checks:basic + +set -u -o pipefail + +DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" +cd "$DIR/../../.." || exit 1 + +REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target/errorprone"} +mkdir -p "$REPORT_DIR" + +REPORT_FILE="$REPORT_DIR/summary.txt" + +MAVEN_OPTIONS='-B -fae --no-transfer-progress -Perrorprone -DskipDocs -DskipRecon -DskipShade' + +declare -i rc + +#shellcheck disable=SC2086 +mvn $MAVEN_OPTIONS test-compile "$@" | tee "${REPORT_DIR}/output.log" +rc=$? + +grep -E "^\[(ERROR|WARNING)\] .*:\[[0-9]+,[0-9]+\] \[[A-Za-z][A-Za-z0-9]+\]" \ + "${REPORT_DIR}/output.log" | awk '!seen[$0]++' > "$REPORT_FILE" Review Comment: It is guaranteed that forked javac always emit errorprone diagnostics with `[WARNING]` or `[ERROR]` prefix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
