shuan1026 opened a new pull request, #11081: URL: https://github.com/apache/ozone/pull/11081
### What changes were proposed in this pull request? TestOzoneClientRetriesOnExceptions#testMaxRetriesByOzoneClient had a no-op assertion: `assertThat(containerList.contains(containerID));` assertThat(boolean) returns an AbstractBooleanAssert that is discarded without a trailing isTrue()/isFalse() call, so this line never actually checked anything. This PR adds .isFalse(): `assertThat(containerList.contains(containerID)).isFalse();` matching the loop's evident intent: each newly-allocated entry should get a containerID not already seen in this loop, before it is added to containerList, per the comment a few lines below about blocks being allocated to "N+1 different containers". Note: with the assertion active, local runs occasionally hit a failure here (~1 in 5 runs), this may be a flaky test and looks related to the pipeline/container allocation behavior discussed under HDDS-16235. Filing that as a follow-up rather than fixing it in this PR, to keep this change scoped to the assertion bug. ### What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-16249 ### How was this patch tested? mvn -pl :ozone-integration-test test -Dtest=TestOzoneClientRetriesOnExceptions -DskipShade -DskipRecon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
