sumitagrawl commented on code in PR #11053:
URL: https://github.com/apache/ozone/pull/11053#discussion_r3843623258


##########
hadoop-hdds/docs/content/design/s3-object-lock.md:
##########
@@ -0,0 +1,198 @@
+---
+title: S3 Object Lock
+summary: Design to support S3 object lock.
+date: 2026-08-18
+jira: HDDS-15945
+status: draft
+author: Chung En Lee
+---
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+
+# S3 Object Lock Design Doc
+
+This design document aims to plan and implement the Object Lock mechanism for 
OBS buckets integrated with Ranger.
+The primary objective is to provide data immutability and tamper-proof 
protection through the object locking feature.
+
+## Background
+With growing demands for data security and compliance, ensuring that critical 
data stored in OBS (Object Storage) is
+protected from accidental or malicious deletion and overwriting has become an 
essential system protection requirement.
+To establish a more rigorous data protection mechanism, we plan to introduce 
the Object Lock feature.
+
+Considering the current system architecture and access control strategies,
+this design integrates with existing Apache Ranger to manage Object Lock 
permissions on OBS buckets.
+Meanwhile, to accelerate core feature delivery, we have decided to exclude 
complex multi-version locking (Versioning Lock) 
+and legacy FSO buckets from this initial release. In addition, support for 
Native ACLs is excluded; Native ACLs typically grant permissions 
+at the granular bucket or object level, whereas Object Lock permission 
management favors broad, role-based authorization,
+creating a conflict in design philosophies. Narrowing the scope allows us to 
focus on the core functionality and ensure a rapid, 
+stable rollout of baseline tamper-proof protection.
+
+## Goal & Non-Goal
+### Goal
+
+- Implement the Object Lock feature on standard OBS buckets, fully integrated 
with Ranger for permission and access control. 
+- Support single-version objects only.
+
+### Non-Goal
+
+- Versioning Lock: Support for locking across multiple object versions is 
deferred (multi-version core features are currently under development).
+- FSO Legacy Buckets: Object Lock support for legacy FSO buckets is excluded.
+- Native ACL Support: Native ACLs will not be used for access control or 
advanced configuration such as Retention Mode (Governance); access management 
is centralized exclusively via Ranger.
+
+### Terminology
+#### Legal Hold
+
+- Definition: Applies an indefinite lock status to an object. The object 
remains protected until an administrator explicitly removes the lock (Remove 
Legal Hold). 
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial / Complete
+- Allowed Operations:
+  - Get Object
+  - Get Legal Hold 
+  - Put Legal Hold (Depends on permission)
+
+#### Retention
+
+- Definition: Configures a fixed retention duration (specified in days or 
years) for an object and applies a specific retention mode. 
+- Retention Modes:
+  - Compliance Mode: The strictest protection tier. Once applied, no user 
(including root/admin) can remove the lock, shorten the duration, or overwrite 
the object before the retention period expires. 
+  - Governance Mode: A flexible protection tier. Standard users are restricted 
by locking rules, but users with bypassgovernance permissions can bypass 
restrictions to perform modifications or deletions.
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial/Complete 
+  - Set Retention Period
+- Allowed Operations:
+  - Get Object
+
+> _**Note**:
+> - Background & Root Cause: A prerequisite for enabling WORM (Write Once, 
Read Many) in AWS S3 is that Object Versioning must be enabled. Under S3 
architecture, executing a Put on a locked object generates a new version 
without affecting the protected prior version; thus, S3 Object Lock primarily 
restricts Delete Object. 
+> - Ozone Implementation Status: Because Ozone's versioning feature is still 
under development, to guarantee absolute immutability during the lock period, 
Ozone will directly block and reject all overwrite operations (such as any form 
of Put or overwrite) on locked objects.
+
+## Design
+
+### Table Changes
+
+#### Bucket Table
+
+Two new fields: objectLockEnabled & defaultRetention.
+
+```protobuf
+  message BucketInfo {
+  // ... existing fields
+  required bool objectLockEnabled = 24 [default = false];
+  optional RetentionConfig defaultRetention = 25;
+  }
+  
+  message RetentionConfig {
+  optional RetentionMode retentionMode = 23;
+  optional uint64 retainUntilDate = 24;
+  }
+  
+  enum RetentionMode {
+    GOVERNANCE = 1;
+    COMPLIANCE = 2;
+  }
+```
+
+
+
+#### Key Table
+
+Two new fields: retentionConfig & legalHold.
+
+```protobuf
+  message KeyInfo {
+  // ... existing fields
+  optional RetentionConfig retentionConfig = 23;
+  optional bool legalHold = 24 [default = false];
+  }
+```
+
+
+
+### Ranger Access Control
+
+- Legal Hold: Introduces three new Access Types—GET_LEGAL_HOLD, 
PUT_LEGAL_HOLD, and CLEAR_LEGAL_HOLD—and adds them to accessTypeRestrictions 
for Keys.

Review Comment:
   If we introduce this feature in Ozone for validation via above api, Having 
same at ranger do have any specific advantage ? 



##########
hadoop-hdds/docs/content/design/s3-object-lock.md:
##########
@@ -0,0 +1,198 @@
+---
+title: S3 Object Lock
+summary: Design to support S3 object lock.
+date: 2026-08-18
+jira: HDDS-15945
+status: draft
+author: Chung En Lee
+---
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+
+# S3 Object Lock Design Doc
+
+This design document aims to plan and implement the Object Lock mechanism for 
OBS buckets integrated with Ranger.
+The primary objective is to provide data immutability and tamper-proof 
protection through the object locking feature.
+
+## Background
+With growing demands for data security and compliance, ensuring that critical 
data stored in OBS (Object Storage) is
+protected from accidental or malicious deletion and overwriting has become an 
essential system protection requirement.
+To establish a more rigorous data protection mechanism, we plan to introduce 
the Object Lock feature.
+
+Considering the current system architecture and access control strategies,
+this design integrates with existing Apache Ranger to manage Object Lock 
permissions on OBS buckets.
+Meanwhile, to accelerate core feature delivery, we have decided to exclude 
complex multi-version locking (Versioning Lock) 
+and legacy FSO buckets from this initial release. In addition, support for 
Native ACLs is excluded; Native ACLs typically grant permissions 
+at the granular bucket or object level, whereas Object Lock permission 
management favors broad, role-based authorization,
+creating a conflict in design philosophies. Narrowing the scope allows us to 
focus on the core functionality and ensure a rapid, 
+stable rollout of baseline tamper-proof protection.
+
+## Goal & Non-Goal
+### Goal
+
+- Implement the Object Lock feature on standard OBS buckets, fully integrated 
with Ranger for permission and access control. 
+- Support single-version objects only.
+
+### Non-Goal
+
+- Versioning Lock: Support for locking across multiple object versions is 
deferred (multi-version core features are currently under development).
+- FSO Legacy Buckets: Object Lock support for legacy FSO buckets is excluded.
+- Native ACL Support: Native ACLs will not be used for access control or 
advanced configuration such as Retention Mode (Governance); access management 
is centralized exclusively via Ranger.
+
+### Terminology
+#### Legal Hold
+
+- Definition: Applies an indefinite lock status to an object. The object 
remains protected until an administrator explicitly removes the lock (Remove 
Legal Hold). 
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial / Complete
+- Allowed Operations:
+  - Get Object
+  - Get Legal Hold 
+  - Put Legal Hold (Depends on permission)
+
+#### Retention
+
+- Definition: Configures a fixed retention duration (specified in days or 
years) for an object and applies a specific retention mode. 
+- Retention Modes:
+  - Compliance Mode: The strictest protection tier. Once applied, no user 
(including root/admin) can remove the lock, shorten the duration, or overwrite 
the object before the retention period expires. 
+  - Governance Mode: A flexible protection tier. Standard users are restricted 
by locking rules, but users with bypassgovernance permissions can bypass 
restrictions to perform modifications or deletions.
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial/Complete 
+  - Set Retention Period
+- Allowed Operations:
+  - Get Object
+
+> _**Note**:
+> - Background & Root Cause: A prerequisite for enabling WORM (Write Once, 
Read Many) in AWS S3 is that Object Versioning must be enabled. Under S3 
architecture, executing a Put on a locked object generates a new version 
without affecting the protected prior version; thus, S3 Object Lock primarily 
restricts Delete Object. 
+> - Ozone Implementation Status: Because Ozone's versioning feature is still 
under development, to guarantee absolute immutability during the lock period, 
Ozone will directly block and reject all overwrite operations (such as any form 
of Put or overwrite) on locked objects.
+
+## Design
+
+### Table Changes
+
+#### Bucket Table
+
+Two new fields: objectLockEnabled & defaultRetention.
+
+```protobuf
+  message BucketInfo {
+  // ... existing fields
+  required bool objectLockEnabled = 24 [default = false];
+  optional RetentionConfig defaultRetention = 25;
+  }
+  
+  message RetentionConfig {
+  optional RetentionMode retentionMode = 23;
+  optional uint64 retainUntilDate = 24;
+  }
+  
+  enum RetentionMode {
+    GOVERNANCE = 1;
+    COMPLIANCE = 2;
+  }
+```
+
+
+
+#### Key Table
+
+Two new fields: retentionConfig & legalHold.
+
+```protobuf
+  message KeyInfo {
+  // ... existing fields
+  optional RetentionConfig retentionConfig = 23;
+  optional bool legalHold = 24 [default = false];
+  }
+```
+
+
+
+### Ranger Access Control
+
+- Legal Hold: Introduces three new Access Types—GET_LEGAL_HOLD, 
PUT_LEGAL_HOLD, and CLEAR_LEGAL_HOLD—and adds them to accessTypeRestrictions 
for Keys.
+- Retention: Introduces the BYPASS_GOVERNANCE Access Type and adds it to 
accessTypeRestrictions for Volumes. 
+
+### New Ozone APIs
+#### ObjectStore
+
+```java
+   public void addRetentionConfig(OzoneObj obj, RetentionArgs retentionArgs);
+   public void addLegalHold(OzoneObj obj, bool hold);
+```
+
+#### OzoneBucket
+
+```java
+public void enableObjectLock(boolean enableObjectLock);
+public void setRetentionConfig(RetentionArgs retentionArgs);
+```
+
+> _**Note**:
+> AWS S3 supports enabling Object Lock and configuring RetentionConfig 
directly during bucket creation. 
+> In Apache Ozone's current design, these settings must be configured via 
dedicated API calls after the bucket has been created.
+
+
+### Impact on Write and Delete Flows
+#### Impact on Put Object Flow
+
+Put Flow: 
+
+![object-lock-put-object.png](object-lock-put-object.png)
+
+During the Create Key phase, the system executes a preliminary WORM check in 
`preExecute` to enforce a fail-fast mechanism:
+
+1. Linearizability does not need to be guaranteed at this stage. 
+2. It avoids Raft consensus overhead, conserving system resources.
+
+During the Commit Key phase, the system performs final WORM validation in 
`validateAndUpdateCache`:
+
+1. It guarantees linearizability, ensuring only one write request can succeed 
simultaneously on a WORM-protected object. 
+2. Keys that fail to commit remain in an Open Key state, and their associated 
metadata and content will be reclaimed periodically by system background 
cleanup. 
+
+#### Impact on Multipart Upload Flow
+
+Multipart Upload adopts the same design logic as Put Object to ensure 
operational consistency:
+1. During Initiate Multipart Upload and Put Part phases, WORM checks are 
executed in `preExecute` for fail-fast behavior (linearizability is not yet 
required, minimizing consensus overhead). 
+2. During the Complete Multipart Upload phase, final validation occurs in 
`validateAndUpdateCache` to guarantee linearizability for writes under locked 
states.
+
+#### Impact on Delete Object Flow
+
+All delete operations must perform WORM validation during the 
`validateAndUpdateCache` phase to preserve linearizability and prevent 
accidental deletion of protected data.

Review Comment:
   do impact for bucket removal or volume removal or directory removal where as 
per soft delete, it moves to deleted directory table, but generally validation 
is not done to deep child ?



##########
hadoop-hdds/docs/content/design/s3-object-lock.md:
##########
@@ -0,0 +1,198 @@
+---
+title: S3 Object Lock
+summary: Design to support S3 object lock.
+date: 2026-08-18
+jira: HDDS-15945
+status: draft
+author: Chung En Lee
+---
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+
+# S3 Object Lock Design Doc
+
+This design document aims to plan and implement the Object Lock mechanism for 
OBS buckets integrated with Ranger.
+The primary objective is to provide data immutability and tamper-proof 
protection through the object locking feature.
+
+## Background
+With growing demands for data security and compliance, ensuring that critical 
data stored in OBS (Object Storage) is
+protected from accidental or malicious deletion and overwriting has become an 
essential system protection requirement.
+To establish a more rigorous data protection mechanism, we plan to introduce 
the Object Lock feature.
+
+Considering the current system architecture and access control strategies,
+this design integrates with existing Apache Ranger to manage Object Lock 
permissions on OBS buckets.
+Meanwhile, to accelerate core feature delivery, we have decided to exclude 
complex multi-version locking (Versioning Lock) 
+and legacy FSO buckets from this initial release. In addition, support for 
Native ACLs is excluded; Native ACLs typically grant permissions 
+at the granular bucket or object level, whereas Object Lock permission 
management favors broad, role-based authorization,
+creating a conflict in design philosophies. Narrowing the scope allows us to 
focus on the core functionality and ensure a rapid, 
+stable rollout of baseline tamper-proof protection.
+
+## Goal & Non-Goal
+### Goal
+
+- Implement the Object Lock feature on standard OBS buckets, fully integrated 
with Ranger for permission and access control. 
+- Support single-version objects only.
+
+### Non-Goal
+
+- Versioning Lock: Support for locking across multiple object versions is 
deferred (multi-version core features are currently under development).
+- FSO Legacy Buckets: Object Lock support for legacy FSO buckets is excluded.
+- Native ACL Support: Native ACLs will not be used for access control or 
advanced configuration such as Retention Mode (Governance); access management 
is centralized exclusively via Ranger.
+
+### Terminology
+#### Legal Hold
+
+- Definition: Applies an indefinite lock status to an object. The object 
remains protected until an administrator explicitly removes the lock (Remove 
Legal Hold). 
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial / Complete
+- Allowed Operations:
+  - Get Object
+  - Get Legal Hold 
+  - Put Legal Hold (Depends on permission)
+
+#### Retention
+
+- Definition: Configures a fixed retention duration (specified in days or 
years) for an object and applies a specific retention mode. 
+- Retention Modes:
+  - Compliance Mode: The strictest protection tier. Once applied, no user 
(including root/admin) can remove the lock, shorten the duration, or overwrite 
the object before the retention period expires. 
+  - Governance Mode: A flexible protection tier. Standard users are restricted 
by locking rules, but users with bypassgovernance permissions can bypass 
restrictions to perform modifications or deletions.
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial/Complete 
+  - Set Retention Period
+- Allowed Operations:
+  - Get Object
+
+> _**Note**:
+> - Background & Root Cause: A prerequisite for enabling WORM (Write Once, 
Read Many) in AWS S3 is that Object Versioning must be enabled. Under S3 
architecture, executing a Put on a locked object generates a new version 
without affecting the protected prior version; thus, S3 Object Lock primarily 
restricts Delete Object. 
+> - Ozone Implementation Status: Because Ozone's versioning feature is still 
under development, to guarantee absolute immutability during the lock period, 
Ozone will directly block and reject all overwrite operations (such as any form 
of Put or overwrite) on locked objects.
+
+## Design
+
+### Table Changes
+
+#### Bucket Table
+
+Two new fields: objectLockEnabled & defaultRetention.

Review Comment:
   Since this object Locking is from S3, what interface via s3 api will be used 
to configure or manage? or its directly via ozone cli?



##########
hadoop-hdds/docs/content/design/s3-object-lock.md:
##########
@@ -0,0 +1,198 @@
+---
+title: S3 Object Lock
+summary: Design to support S3 object lock.
+date: 2026-08-18
+jira: HDDS-15945
+status: draft
+author: Chung En Lee
+---
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+
+# S3 Object Lock Design Doc
+
+This design document aims to plan and implement the Object Lock mechanism for 
OBS buckets integrated with Ranger.
+The primary objective is to provide data immutability and tamper-proof 
protection through the object locking feature.
+
+## Background
+With growing demands for data security and compliance, ensuring that critical 
data stored in OBS (Object Storage) is
+protected from accidental or malicious deletion and overwriting has become an 
essential system protection requirement.
+To establish a more rigorous data protection mechanism, we plan to introduce 
the Object Lock feature.
+
+Considering the current system architecture and access control strategies,
+this design integrates with existing Apache Ranger to manage Object Lock 
permissions on OBS buckets.
+Meanwhile, to accelerate core feature delivery, we have decided to exclude 
complex multi-version locking (Versioning Lock) 
+and legacy FSO buckets from this initial release. In addition, support for 
Native ACLs is excluded; Native ACLs typically grant permissions 
+at the granular bucket or object level, whereas Object Lock permission 
management favors broad, role-based authorization,
+creating a conflict in design philosophies. Narrowing the scope allows us to 
focus on the core functionality and ensure a rapid, 
+stable rollout of baseline tamper-proof protection.
+
+## Goal & Non-Goal
+### Goal
+
+- Implement the Object Lock feature on standard OBS buckets, fully integrated 
with Ranger for permission and access control. 
+- Support single-version objects only.
+
+### Non-Goal
+
+- Versioning Lock: Support for locking across multiple object versions is 
deferred (multi-version core features are currently under development).
+- FSO Legacy Buckets: Object Lock support for legacy FSO buckets is excluded.
+- Native ACL Support: Native ACLs will not be used for access control or 
advanced configuration such as Retention Mode (Governance); access management 
is centralized exclusively via Ranger.
+
+### Terminology
+#### Legal Hold
+
+- Definition: Applies an indefinite lock status to an object. The object 
remains protected until an administrator explicitly removes the lock (Remove 
Legal Hold). 
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial / Complete
+- Allowed Operations:
+  - Get Object
+  - Get Legal Hold 
+  - Put Legal Hold (Depends on permission)
+
+#### Retention
+
+- Definition: Configures a fixed retention duration (specified in days or 
years) for an object and applies a specific retention mode. 
+- Retention Modes:
+  - Compliance Mode: The strictest protection tier. Once applied, no user 
(including root/admin) can remove the lock, shorten the duration, or overwrite 
the object before the retention period expires. 
+  - Governance Mode: A flexible protection tier. Standard users are restricted 
by locking rules, but users with bypassgovernance permissions can bypass 
restrictions to perform modifications or deletions.
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial/Complete 
+  - Set Retention Period
+- Allowed Operations:
+  - Get Object
+
+> _**Note**:
+> - Background & Root Cause: A prerequisite for enabling WORM (Write Once, 
Read Many) in AWS S3 is that Object Versioning must be enabled. Under S3 
architecture, executing a Put on a locked object generates a new version 
without affecting the protected prior version; thus, S3 Object Lock primarily 
restricts Delete Object. 
+> - Ozone Implementation Status: Because Ozone's versioning feature is still 
under development, to guarantee absolute immutability during the lock period, 
Ozone will directly block and reject all overwrite operations (such as any form 
of Put or overwrite) on locked objects.
+
+## Design
+
+### Table Changes
+
+#### Bucket Table
+
+Two new fields: objectLockEnabled & defaultRetention.
+
+```protobuf
+  message BucketInfo {
+  // ... existing fields
+  required bool objectLockEnabled = 24 [default = false];
+  optional RetentionConfig defaultRetention = 25;
+  }
+  
+  message RetentionConfig {
+  optional RetentionMode retentionMode = 23;
+  optional uint64 retainUntilDate = 24;
+  }
+  
+  enum RetentionMode {
+    GOVERNANCE = 1;
+    COMPLIANCE = 2;
+  }
+```
+
+
+
+#### Key Table
+
+Two new fields: retentionConfig & legalHold.
+
+```protobuf
+  message KeyInfo {
+  // ... existing fields
+  optional RetentionConfig retentionConfig = 23;
+  optional bool legalHold = 24 [default = false];
+  }
+```
+
+
+
+### Ranger Access Control
+
+- Legal Hold: Introduces three new Access Types—GET_LEGAL_HOLD, 
PUT_LEGAL_HOLD, and CLEAR_LEGAL_HOLD—and adds them to accessTypeRestrictions 
for Keys.

Review Comment:
   how ranger and ozone role will combine in validation?



##########
hadoop-hdds/docs/content/design/s3-object-lock.md:
##########
@@ -0,0 +1,198 @@
+---
+title: S3 Object Lock
+summary: Design to support S3 object lock.
+date: 2026-08-18
+jira: HDDS-15945
+status: draft
+author: Chung En Lee
+---
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+
+# S3 Object Lock Design Doc
+
+This design document aims to plan and implement the Object Lock mechanism for 
OBS buckets integrated with Ranger.
+The primary objective is to provide data immutability and tamper-proof 
protection through the object locking feature.
+
+## Background
+With growing demands for data security and compliance, ensuring that critical 
data stored in OBS (Object Storage) is
+protected from accidental or malicious deletion and overwriting has become an 
essential system protection requirement.
+To establish a more rigorous data protection mechanism, we plan to introduce 
the Object Lock feature.
+
+Considering the current system architecture and access control strategies,
+this design integrates with existing Apache Ranger to manage Object Lock 
permissions on OBS buckets.
+Meanwhile, to accelerate core feature delivery, we have decided to exclude 
complex multi-version locking (Versioning Lock) 
+and legacy FSO buckets from this initial release. In addition, support for 
Native ACLs is excluded; Native ACLs typically grant permissions 
+at the granular bucket or object level, whereas Object Lock permission 
management favors broad, role-based authorization,
+creating a conflict in design philosophies. Narrowing the scope allows us to 
focus on the core functionality and ensure a rapid, 
+stable rollout of baseline tamper-proof protection.
+
+## Goal & Non-Goal
+### Goal
+
+- Implement the Object Lock feature on standard OBS buckets, fully integrated 
with Ranger for permission and access control. 
+- Support single-version objects only.
+
+### Non-Goal
+
+- Versioning Lock: Support for locking across multiple object versions is 
deferred (multi-version core features are currently under development).
+- FSO Legacy Buckets: Object Lock support for legacy FSO buckets is excluded.
+- Native ACL Support: Native ACLs will not be used for access control or 
advanced configuration such as Retention Mode (Governance); access management 
is centralized exclusively via Ranger.
+
+### Terminology
+#### Legal Hold
+
+- Definition: Applies an indefinite lock status to an object. The object 
remains protected until an administrator explicitly removes the lock (Remove 
Legal Hold). 
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial / Complete
+- Allowed Operations:
+  - Get Object
+  - Get Legal Hold 
+  - Put Legal Hold (Depends on permission)
+
+#### Retention
+
+- Definition: Configures a fixed retention duration (specified in days or 
years) for an object and applies a specific retention mode. 
+- Retention Modes:
+  - Compliance Mode: The strictest protection tier. Once applied, no user 
(including root/admin) can remove the lock, shorten the duration, or overwrite 
the object before the retention period expires. 
+  - Governance Mode: A flexible protection tier. Standard users are restricted 
by locking rules, but users with bypassgovernance permissions can bypass 
restrictions to perform modifications or deletions.
+- Restricted Operations:
+  - Put Object 
+  - Delete Object 
+  - Multipart Initial/Complete 
+  - Set Retention Period
+- Allowed Operations:
+  - Get Object
+
+> _**Note**:
+> - Background & Root Cause: A prerequisite for enabling WORM (Write Once, 
Read Many) in AWS S3 is that Object Versioning must be enabled. Under S3 
architecture, executing a Put on a locked object generates a new version 
without affecting the protected prior version; thus, S3 Object Lock primarily 
restricts Delete Object. 
+> - Ozone Implementation Status: Because Ozone's versioning feature is still 
under development, to guarantee absolute immutability during the lock period, 
Ozone will directly block and reject all overwrite operations (such as any form 
of Put or overwrite) on locked objects.
+
+## Design
+
+### Table Changes
+
+#### Bucket Table
+
+Two new fields: objectLockEnabled & defaultRetention.
+
+```protobuf
+  message BucketInfo {
+  // ... existing fields
+  required bool objectLockEnabled = 24 [default = false];
+  optional RetentionConfig defaultRetention = 25;
+  }
+  
+  message RetentionConfig {
+  optional RetentionMode retentionMode = 23;
+  optional uint64 retainUntilDate = 24;
+  }
+  
+  enum RetentionMode {
+    GOVERNANCE = 1;
+    COMPLIANCE = 2;
+  }
+```
+
+
+
+#### Key Table
+
+Two new fields: retentionConfig & legalHold.
+
+```protobuf
+  message KeyInfo {
+  // ... existing fields
+  optional RetentionConfig retentionConfig = 23;
+  optional bool legalHold = 24 [default = false];
+  }
+```
+
+
+
+### Ranger Access Control
+
+- Legal Hold: Introduces three new Access Types—GET_LEGAL_HOLD, 
PUT_LEGAL_HOLD, and CLEAR_LEGAL_HOLD—and adds them to accessTypeRestrictions 
for Keys.
+- Retention: Introduces the BYPASS_GOVERNANCE Access Type and adds it to 
accessTypeRestrictions for Volumes. 
+
+### New Ozone APIs
+#### ObjectStore
+
+```java
+   public void addRetentionConfig(OzoneObj obj, RetentionArgs retentionArgs);
+   public void addLegalHold(OzoneObj obj, bool hold);
+```
+
+#### OzoneBucket
+
+```java
+public void enableObjectLock(boolean enableObjectLock);
+public void setRetentionConfig(RetentionArgs retentionArgs);
+```
+
+> _**Note**:
+> AWS S3 supports enabling Object Lock and configuring RetentionConfig 
directly during bucket creation. 
+> In Apache Ozone's current design, these settings must be configured via 
dedicated API calls after the bucket has been created.
+
+
+### Impact on Write and Delete Flows
+#### Impact on Put Object Flow
+
+Put Flow: 
+
+![object-lock-put-object.png](object-lock-put-object.png)
+
+During the Create Key phase, the system executes a preliminary WORM check in 
`preExecute` to enforce a fail-fast mechanism:
+
+1. Linearizability does not need to be guaranteed at this stage. 
+2. It avoids Raft consensus overhead, conserving system resources.
+
+During the Commit Key phase, the system performs final WORM validation in 
`validateAndUpdateCache`:
+
+1. It guarantees linearizability, ensuring only one write request can succeed 
simultaneously on a WORM-protected object. 
+2. Keys that fail to commit remain in an Open Key state, and their associated 
metadata and content will be reclaimed periodically by system background 
cleanup. 
+
+#### Impact on Multipart Upload Flow
+
+Multipart Upload adopts the same design logic as Put Object to ensure 
operational consistency:
+1. During Initiate Multipart Upload and Put Part phases, WORM checks are 
executed in `preExecute` for fail-fast behavior (linearizability is not yet 
required, minimizing consensus overhead). 
+2. During the Complete Multipart Upload phase, final validation occurs in 
`validateAndUpdateCache` to guarantee linearizability for writes under locked 
states.
+
+#### Impact on Delete Object Flow
+
+All delete operations must perform WORM validation during the 
`validateAndUpdateCache` phase to preserve linearizability and prevent 
accidental deletion of protected data.
+
+## Performance
+
+Introducing WORM validation into critical execution paths (such as Create Key 
and Commit Key) incurs minor overhead.
+To minimize impact, this design employs a two-phase validation strategy: 
preliminary filtering in `preExecute` provides fail-fast pruning to prevent 
invalid requests from reaching the consensus layer, followed by atomic 
validation in `validateAndUpdateCache` for linearizability.
+Preliminary assessments indicate that the additional metadata lookups impose 
an acceptable impact on overall system throughput and latency. Metrics will be 
continuously monitored and tuned as necessary.
+
+## Security
+
+Centralized access control via Ranger ensures all Object Lock operations (such 
as Retention Policy configuration and Legal Hold management) are enforced under 
strict access permissions. Dedicated Access Types (BYPASS_GOVERNANCE, 
PUT_LEGAL_HOLD, etc.) enforce the Principle of Least Privilege, preventing 
unauthorized tampering or removal of locks and enhancing data immutability.

Review Comment:
   Like ranger can clear / update policy, and super admin role to update / 
delete bucket or file policy ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to