echonesis commented on PR #11108: URL: https://github.com/apache/ozone/pull/11108#issuecomment-5428130402
> Thanks @echonesis Overall, this looks good. I left a few inline comments, mostly around error classification and test scope. > > I also noticed other related IPv6 issues (`getHttpAddressForOMPeerNode` and `getHttpsAddressForOMPeerNode`) in the same file. The fix would be the same approach used elsewhere in this PR. > > Would it make sense to fold those in here, or should they go on a separate Jira under the epic? > > https://github.com/apache/ozone/blob/d3198e4349ba6b6951ef4fb2f1eabdde3afa40a2/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java#L618-L620 Thanks @chihsuan Good catch. I folded both methods into HDDS-16139 because they have the same root cause and can use the same existing getHostPortString helper. I also added IPv6 coverage for both peer HTTP and HTTPS addresses in TestOmUtils. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
