jojochuang commented on PR #11125: URL: https://github.com/apache/ozone/pull/11125#issuecomment-5429875906
Added unit-test coverage on a fork branch — please feel free to cherry-pick or copy into this PR. **Branch:** https://github.com/jojochuang/ozone/tree/HDDS-16298-add-tests **New file:** [`TestECBlockChecksumComputer.java`](https://github.com/jojochuang/ozone/blob/HDDS-16298-add-tests/hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/checksum/TestECBlockChecksumComputer.java) Mirrors `TestReplicatedBlockChecksumComputer` for EC: - `testComputeMd5Crc` — builds stripe checksum with parity padding stripped, asserts output equals `MD5Hash.digest(dataChecksumBytes)` (would fail on the pre-fix double-`digest()` bug). - `testComputeCompositeCrc` — asserts composite CRC bytes against an independently computed `CrcComposer` result over parity-stripped stripe data. Verified locally: ``` mvn -pl :ozone-client test -Dtest=TestECBlockChecksumComputer -DskipShade -DskipRecon -DskipDocs ``` Both tests pass with your one-line fix applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
