Eason09053360 commented on code in PR #11096:
URL: https://github.com/apache/ozone/pull/11096#discussion_r3869327956
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java:
##########
@@ -115,6 +115,9 @@
public final class OzoneManagerRatisServer {
private static final Logger LOG =
LoggerFactory.getLogger(OzoneManagerRatisServer.class);
+ /** Superseded by {@code ozone.om.ha.raft.server.retrycache.expirytime},
still honoured if set. */
+ private static final String RETRY_CACHE_TIMEOUT_DEPRECATED_KEY =
"ozone.om.ratis.server.retry.cache.timeout";
Review Comment:
Thanks for reviewing @szetszwo! That was the first revision of this patch,
but DeprecationDelta is a plain string alias, which broke two things (see
@chihsuan's comment above):
Ratis parses a unit-less value as seconds, while the old key was always read
as milliseconds — a cluster with 600000 would jump from 10 min to ~6.9 days.
No warning fires: Hadoop only logs on get()/set(), and the replacement key
always carries the generated 300s default, so conf.get(oldKey) is never null
and we can't tell whether the operator set anything.
So the current revision applies the old key explicitly after
getOMHAConfigs() (reversing the original override bug), only when it is
actually set, in milliseconds, with the warning logged.
Happy to switch to addDeprecatedKeys() if you prefer the uniform mechanism —
it just means accepting the unit change in the release note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
