sodonnel commented on code in PR #11023:
URL: https://github.com/apache/ozone/pull/11023#discussion_r3871071586
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -527,17 +531,10 @@ public void sendThrottledReplicationCommand(ContainerInfo
containerInfo,
DatanodeDetails source = selectAndOptionallyExcludeDatanode(
1, sourceWithCmds);
- try {
- ReplicateContainerCommand cmd = ReplicateContainerCommand.toTarget(
- containerID, target,
- nodeManager.getLowestApparentVersion(source, target));
- cmd.setReplicaIndex(replicaIndex);
- sendDatanodeCommand(cmd, containerInfo, source);
- } catch (NodeNotFoundException e) {
- throw new IllegalArgumentException("Datanode not found in NodeManager
while sending replication "
- + "command for container " + containerID + " from source " + source
+ " to target " + target
- + ". Should not happen", e);
- }
+ ReplicateContainerCommand cmd = ReplicateContainerCommand.toTarget(
Review Comment:
The catch block has been removed here - is that intentional? I don't recall
why we did this (catch NodeNotFound and throw IAE instead) but there must have
been some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
