yandrey321 commented on code in PR #11118:
URL: https://github.com/apache/ozone/pull/11118#discussion_r3876191627
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -536,38 +537,49 @@ private OzoneManagerProtocolProtos.PurgePathRequest
wrapPurgeRequest(
private List<OzoneManagerProtocolProtos.OMResponse>
submitPurgePathsWithBatching(List<PurgePathRequest> requests,
String snapTableKey, UUID expectedPreviousSnapshotId,
Map<VolumeBucketId, BucketNameInfo> bucketNameInfoMap) {
+ // Group purge paths by their owning bucket so that every submitted purge
transaction contains paths from a single
+ // bucket only. This keeps the apply side acquiring exactly one bucket
write lock per transaction; combined with
+ // apply-side chunking within that lock, a large background directory
purge cannot starve readers on other buckets.
Review Comment:
[HDDS-16297](https://issues.apache.org/jira/browse/HDDS-16297) will limit a
number of keys/dirs belong to the single bucket handled in the single request
in a way that would not hold concurrent user requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
