Gargi-jais11 commented on code in PR #11061: URL: https://github.com/apache/ozone/pull/11061#discussion_r3878022491
########## hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/signature/TestChunksValidator.java: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.s3.signature; + +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import java.util.Arrays; +import org.apache.hadoop.ozone.s3.exception.OS3Exception; +import org.junit.jupiter.api.Test; + +/** + * Verifies {@link ChunksValidator} against the canonical AWS SigV4 streaming + * example (secret {@code wJalr...}, region us-east-1, service s3, date + * 20130524, a 66560-byte payload of 'a' in chunks of 65536 + 1024 + 0). + * + * @see <a href="https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html";> + * Signature Calculation: Transfer Payload in Multiple Chunks</a> + */ +class TestChunksValidator { Review Comment: End to End Test means adding integration test. Those are still stubs and mocks. No worries I found this https://issues.apache.org/jira/browse/HDDS-15143 ticket which will add the test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
