adoroszlai commented on a change in pull request #2436:
URL: https://github.com/apache/ozone/pull/2436#discussion_r672751362
##########
File path: hadoop-ozone/dist/src/main/smoketest/s3/bucketcreate.robot
##########
@@ -32,7 +32,10 @@ Create new bucket
Create bucket
Create bucket which already exists
- Create bucket with name ${BUCKET}
+ Create bucket with name ${PREFIX}-bucket
+ ${result} = Execute AWSS3APICli list-buckets | jq -r
'.Buckets[].Name'
+ Should contain ${result}
${PREFIX}-bucket
+ Create bucket with name ${PREFIX}-bucket
Review comment:
`Create bucket` generates a random name and returns it. Also, `Create
bucket with name` verifies that the bucket exists by checking the response for
`create-bucket`.
So I think the fix can be simplified a bit:
```suggestion
${bucket} = Create bucket
Create bucket with name ${bucket}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
