henry3260 commented on code in PR #11157:
URL: https://github.com/apache/ozone/pull/11157#discussion_r3886072104


##########
hadoop-ozone/dist/src/main/smoketest/s3/bucketlifecycle.robot:
##########
@@ -61,3 +61,24 @@ Delete bucket lifecycle configuration when none exists
     ${bucket} =         Create bucket
     ${result} =         Execute AWSS3APICli     delete-bucket-lifecycle 
--bucket ${bucket}
                         Should Be Empty         ${result}
+
+Head object reports expiration of matching lifecycle rule

Review Comment:
   > The two new robot cases pin only that the `Expiration` header is present 
or absent, but do not assert its content (the expiry date and rule-id). Given 
that the PR author explicitly calls out the exact header format in the unit 
tests, adding a `Should Match Regexp` assertion on the value would make the 
smoke test catch format regressions in a compose environment where the unit 
tests do not run.
   
   Applied!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to