rjgoyln commented on PR #11130: URL: https://github.com/apache/ozone/pull/11130#issuecomment-5467378426
> o, the description still mentions the removed helper overload. Could you update PR description to reflect the changes? Thanks! Thanks for the review! I've confirmed them against the code. Regarding how to track them, I suggest splitting the two: * **Unbracketed IPv6 (Silent Failure):** Let's track this in **HDDS-16308**. As you noted, Guava now brackets it into `[2001:db8::1:9862]:9862`, turning a loud failure into a silent one. Rejecting this ambiguous form outright fits perfectly into the scope of HDDS-16308's config validation. * **SPNEGO `_HOST` resolving to `[::]`:** I suggest filing a **new JIRA** under HDDS-15763 for this. Since this is about deciding how `_HOST` should resolve when intentionally binding to a wildcard (rather than just rejecting a bad config), keeping it separate from HDDS-16308 makes sense. Let me know if this split sounds right, and I'll file the new ticket! *(Also, the PR description has been updated and no longer refers to the removed helper overload.)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
