henrybear327 commented on code in PR #10934:
URL: https://github.com/apache/ozone/pull/10934#discussion_r3894163201
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/local/LocalOzoneCluster.java:
##########
@@ -351,28 +363,25 @@ private void stopScm() {
}
}
- private void configureLocalDefaults(OzoneConfiguration conf) {
- conf.set(OZONE_METADATA_DIRS, metadataDir().toString());
+ private void configureLocalDefaults(OzoneConfiguration conf) throws
IOException {
+ setLocalOverride(conf, OZONE_METADATA_DIRS, metadataDir().toString());
Review Comment:
> Suggestion: keep plain conf.set() for keys whose required value is a path
the runtime generates and owns, and reserve setLocalOverride for keys where a
conflicting user value would actually change observable cluster behaviour.
Attempted to follow this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
