sreejasahithi commented on code in PR #11132:
URL: https://github.com/apache/ozone/pull/11132#discussion_r3895666258
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java:
##########
@@ -926,12 +924,11 @@ public static Collection<HostAndPort>
getSCMAddressForDatanodes(ConfigurationSou
* Null if there is any wrongly configured SCM address. Note that the
returned collection
* might not be ordered the same way as the requested SCM node IDs
*/
- public static Collection<Pair<String, HostAndPort>>
getSCMAddressForDatanodes(
+ public static Collection<ScmNodeAddress> getSCMAddressForDatanodes(
Review Comment:
instead of Collection<ScmNodeAddress> we can make it as List<ScmNodeAddress>
Similarly update in other locations.
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/checksum/ContainerMerkleTreeTestUtils.java:
##########
@@ -183,9 +182,9 @@ public static List<BlockData>
getDeletedBlockData(ConfigurationSource conf, long
}
/**
- * Returns a Pair of merkle tree and the expected container diff for that
merkle tree.
+ * Returns the merkle tree and expected diff for that tree.
*/
- public static Pair<ContainerProtos.ContainerMerkleTree, ContainerDiffReport>
+ public static ContainerDiffResult
Review Comment:
we can have it package private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
