shuan1026 opened a new pull request, #11198: URL: https://github.com/apache/ozone/pull/11198
## What changes were proposed in this pull request? `--dry-run` of `ozone repair datanode upgrade-container-schema` still wrote the permanent `upgrade.complete` marker. The real run then skipped every marked volume. Details are on the Jira. This patch: - Creates `upgrade.complete` only when `e == null && r.isSuccess() && !isDryRun()`. Dry-run still deletes `upgrade.lock`. - Passes `lockFile` (not `file`) to the lock-delete error log in the same `whenComplete`. - Asserts in `TestUpgradeContainerSchema.testUpgrade` that the marker is absent after dry-run and present after a real run. This does not delete markers already left by an older dry-run. Operators who already ran `--dry-run` should remove each volume's `hddsRootDir/upgrade.complete` before the real upgrade. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-16378 ## How was this patch tested? - `TestUpgradeContainerSchema` (including the new `upgrade.complete` existence checks on both `dryRun` parameter values). - ci: https://github.com/shuan1026/ozone/actions/runs/33729155957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
