Navin Kumar created HDDS-16385:
----------------------------------
Summary: Minor cleanups in NodeDecommissionManager
Key: HDDS-16385
URL: https://issues.apache.org/jira/browse/HDDS-16385
Project: Apache Ozone
Issue Type: Task
Components: SCM
Reporter: Navin Kumar
Assignee: Navin Kumar
# In {{{}NodeDecommissionManager.parseHostname(){}}}, the
{{InvalidHostStringException}} message has a typo — {{"does not contain a value
hostname or hostname:port definition"}} should read {{{}"a valid hostname"{}}}.
# In {{{}NodeDecommissionManager.checkIfMaintenancePossible(){}}}, the list
copy is redundant — {{List<DatanodeDetails> validDns =
dns.stream().collect(Collectors.toList());}}
Followed by {{Collections.copy(validDns, dns);}} Which copies {{dns}} twice,
and should be simplified to {{List<DatanodeDetails> validDns = new
ArrayList<>(dns);}}
Which is matching with other implementations like
{{checkIfDecommissionPossible() definition.}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
