arunsarin85 commented on code in PR #11212:
URL: https://github.com/apache/ozone/pull/11212#discussion_r3972233484
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/service/TestDirectoryDeletingServiceWithFSO.java:
##########
@@ -787,9 +790,10 @@ public void testDirDeletedTableCleanUpForSnapshot() throws
Exception {
assertSubPathsCount(dirDeletingService::getMovedDirsCount, 4);
assertSubPathsCount(dirDeletingService::getDeletedDirsCount, 0);
- // Manual cleanup deletedDirTable for next tests
+ // Manual cleanup deletedDirTable for next tests - completed in @AfterEach
cleanup()
client.getObjectStore().deleteSnapshot(volumeName, bucketName, "snap1");
- cleanupTables();
+ snapshotCountAfterTest = 0;
Review Comment:
snapshotToDeleteInCleanup = "snap1", snapshotCountAfterTest = 0, and
needsTableCleanup = true are now set immediately after createSnapshot("snap1").
The teardown attempts deleteSnapshot (ignoring "already deleted" errors), then
waits for the table to reach 0, then calls cleanupTables. A mid-test failure no
longer leaves snap1 or dirty tables behind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
