Copilot commented on code in PR #11241:
URL: https://github.com/apache/ozone/pull/11241#discussion_r4012201940
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -546,8 +546,8 @@ protected void initializeOmTables(CacheType cacheType,
s3RevokedStsTokenTable = initializer.get(
OMDBDefinition.S3_REVOKED_STS_TOKEN_TABLE_DEF, cacheType);
- lifecycleConfigurationTable =
initializer.get(OMDBDefinition.LIFECYCLE_CONFIGURATION_TABLE_DEF, cacheType);
- lifecycleScanStateTable =
initializer.get(OMDBDefinition.LIFECYCLE_SCAN_STATE_TABLE_DEF, cacheType);
+ lifecycleConfigurationTable =
initializer.get(OMDBDefinition.LIFECYCLE_CONFIGURATION_TABLE_DEF);
Review Comment:
`listLifecycleConfigurations()` still iterates only
`lifecycleConfigurationTable.cacheIterator()` and therefore assumes a full
cache. With this table now using `PARTIAL_CACHE`, the cache is empty after OM
restart or cleanup, so the daily `KeyLifecycleService` scan returns no policies
and existing lifecycle rules stop being evaluated. Update the listing path to
merge the RocksDB iterator with pending cache entries (including tombstones),
or keep this table on `FULL_CACHE` until that is implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
