HesandaLiyanage commented on PR #11262:
URL: https://github.com/apache/ozone/pull/11262#issuecomment-5739918013
Hi @chihsuan , thank you so much for the review!
I have addressed all the feedback in the latest commit:
- Signaled task reinitialization (`tasksFailed`) directly on sync failure
instead of retrying `process()`, preventing double-counting in incremental
counting tasks.
- Recorded failures in `taskMetrics` when sync fails.
- Handled `dbStore == null` by returning `false` so cursors never advance
without durability guarantees.
- Trimmed the rationale comments down to the canonical `syncReconDbLog()`
javadoc.
- Updated the unit tests to verify that `process()` is not retried on sync
failure, and added a test for the null `dbStore` path.
Please let me know if there's anything else!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
