andyhuangdev commented on PR #11263: URL: https://github.com/apache/ozone/pull/11263#issuecomment-5743007442
> Thanks @andyhuangdev. LGTM. > > Just to confirm in the description > > > The remaining branch contains a no-op assertion; correcting it exposes the intermittent failure. > > Was the no-op assertion already fixed in [HDDS-16084](https://issues.apache.org/jira/browse/HDDS-16084), with this PR fixing the flakiness exposed by that change? Yes, that's correct. HDDS-16084 (#11056) already fixed the no-op assertion. This PR addresses the flakiness exposed by that fix by checking the root cause type and message, while retaining the assertion that close() throws IOException. It also removes the unreachable CompletionException branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
