captainzmc commented on a change in pull request #2452:
URL: https://github.com/apache/ozone/pull/2452#discussion_r675282520
##########
File path:
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto
##########
@@ -391,7 +393,7 @@ enum ChecksumType {
message WriteChunkRequestProto {
required DatanodeBlockID blockID = 1;
- required ChunkInfo chunkData = 2;
+ optional ChunkInfo chunkData = 2;
Review comment:
Changed this from required to optional is compatible. The previous
interface WriteChunkRequestProto must have chunkData. Init stream will use
WriteChunkRequestProto, but do not require chunkData. Just like we implemented
in the [POC
code](https://github.com/captainzmc/hadoop-ozone/blob/streaming-poc-2/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java#L162).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
