[
https://issues.apache.org/jira/browse/HDDS-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze updated HDDS-16517:
------------------------------
Description:
We may simplify XceiverClientShortCircuit in order to support concurrent access:
- Add a name field and do not use domainSocket for printing messages.
- Refactor timer to an inner class and make all methods synchronized.
- Simplify sendCommandWithTraceID which calls CompletableFuture.get() to obtain
responseProto and then use it to create another CompletableFuture -- just use
the first CompletableFuture.
- Change requestSent and responseReceived to AtomicLong -- they are just for
printing debug messages.
- Remove RequestEntry.sentTimeNs which is just for printing debug messages.
Print it in a different location.
- Remove RequestEntry.timerTask -- use CompletableFuture.whenComplete(..)
- Convert prefix to a local variable.
- Remove the unused config.
was:
We may simplify XceiverClientShortCircuit in order to support concurrent access:
- Add a name field and do not use domainSocket for printing messages.
- Refactor timer to an inner class and make all methods synchronized.
- Simplify sendCommandWithTraceID which calls CompletableFuture.get() to obtain
responseProto and then use it to create another CompletableFuture -- just use
the first CompletableFuture.
- Change requestSent and responseReceived to AtomicLong -- they are just for
printing debug messages.
- Remove RequestEntry.sentTimeNs which is just for printing debug messages.
Print it in a different location.
- Convert prefix to a local variable.
- Remove the unused config.
> Simplify XceiverClientShortCircuit for HDDS-16335
> -------------------------------------------------
>
> Key: HDDS-16517
> URL: https://issues.apache.org/jira/browse/HDDS-16517
> Project: Apache Ozone
> Issue Type: Improvement
> Components: Ozone Client
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
>
> We may simplify XceiverClientShortCircuit in order to support concurrent
> access:
> - Add a name field and do not use domainSocket for printing messages.
> - Refactor timer to an inner class and make all methods synchronized.
> - Simplify sendCommandWithTraceID which calls CompletableFuture.get() to
> obtain responseProto and then use it to create another CompletableFuture --
> just use the first CompletableFuture.
> - Change requestSent and responseReceived to AtomicLong -- they are just for
> printing debug messages.
> - Remove RequestEntry.sentTimeNs which is just for printing debug messages.
> Print it in a different location.
> - Remove RequestEntry.timerTask -- use CompletableFuture.whenComplete(..)
> - Convert prefix to a local variable.
> - Remove the unused config.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
