peterxcli commented on code in PR #11293:
URL: https://github.com/apache/ozone/pull/11293#discussion_r4062133289
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java:
##########
@@ -426,6 +443,8 @@ public OmBucketInfo
withOperationalPropertiesFrom(OmBucketInfo source) {
* Builder for OmBucketInfo.
*/
public static class Builder extends WithObjectID.Builder<OmBucketInfo> {
+ private boolean objectLockEnabled;
+ private Retention defaultRetention;
Review Comment:
same
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java:
##########
@@ -113,8 +113,13 @@ public final class OmBucketInfo extends WithObjectID
implements Auditable, CopyO
*/
private final ImmutableMap<String, String> tags;
+ private final boolean objectLockEnabled;
+ private final Retention defaultRetention;
+
private OmBucketInfo(Builder b) {
super(b);
+ this.objectLockEnabled = b.objectLockEnabled;
+ this.defaultRetention = b.defaultRetention;
Review Comment:
nit: place new field at the end(line 143)
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -112,8 +112,15 @@ public final class OmKeyInfo extends WithParentObjectId
// been modified.
private final Long expectedDataGeneration;
+ private final Long retentionDate;
+ private final Retention retentionConfig;
+ private final Boolean legalHold;
+
private OmKeyInfo(Builder b) {
super(b);
+ this.retentionDate = b.retentionDate;
+ this.retentionConfig = b.retentionConfig;
+ this.legalHold = b.legalHold;
Review Comment:
same
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -494,6 +513,9 @@ public String toString() {
* Builder of OmKeyInfo.
*/
public static class Builder extends WithParentObjectId.Builder<OmKeyInfo> {
+ private Long retentionDate;
+ private Retention retentionConfig;
+ private Boolean legalHold;
Review Comment:
same
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -522,6 +544,9 @@ public Builder() {
public Builder(OmKeyInfo obj) {
super(obj);
this.acls = AclListBuilder.of(obj.acls);
+ this.retentionDate = obj.retentionDate;
+ this.retentionConfig = obj.retentionConfig;
+ this.legalHold = obj.legalHold;
Review Comment:
elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
