chihsuan commented on PR #11291: URL: https://github.com/apache/ozone/pull/11291#issuecomment-5764004491
Thanks for the patch! @rich7420 I looked into this more. IMO, this and HDDS-16437 are the same bug. The counters get updated without checking what was submitted. Skipping them on failure means successful batches never get counted, and 16437 would undo the new tests. I think we could fold 16437 into this PR and only count the batches that went through. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
