Copilot commented on code in PR #11304:
URL: https://github.com/apache/ozone/pull/11304#discussion_r4078417978
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java:
##########
@@ -250,7 +250,7 @@ public static final class ReplicationConfig {
)
private boolean perVolumeEnabled = false;
- @Config(key = PER_VOLUME_STREAMS_LIMIT_KEY,
+ @Config(key = "hdds.datanode.replication.per.volume.streams.limit",
Review Comment:
`PER_VOLUME_STREAMS_LIMIT_KEY` is already a compile-time constant that
evaluates to this exact fully-qualified string (`PREFIX +
".per.volume.streams.limit"`). The reflection injector and config-file
generator consume the resolved `Config.key()`, so replacing the constant with
this literal does not change the effective key or fix the reported
`ozone-site.xml` regression; it only creates a second source of truth. Please
fix the code path that is actually producing/looking up the short key and add a
regression assertion for the effective generated/injected key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
