umamaheswararao commented on pull request #2442: URL: https://github.com/apache/ozone/pull/2442#issuecomment-885752648
Thank you @szetszwo for the updates. The latest patch looks good to me. However I have one point to discuss: Most of the abstract APIs are related to commitWatcher. When we have other implementations like standalone or EC, they don't need most of them. is it a good idea to have them empty implementation in BOS, so that it will not force other classes to implement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
