ferhui commented on a change in pull request #2439:
URL: https://github.com/apache/ozone/pull/2439#discussion_r676237618
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketAddAclRequest.java
##########
@@ -134,7 +127,9 @@ void onComplete(boolean operationResult, IOException
exception,
exception, getOmRequest().getUserInfo()));
if (operationResult) {
- LOG.debug("Add acl: {} to path: {} success!", getAcls(), getPath());
+ if (LOG.isDebugEnabled()) {
Review comment:
Is this for performance? Maybe there is no problem here.
It is recommended to use parameterized messages.
Please see http://www.slf4j.org/faq.html#logging_performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
