chihsuan commented on code in PR #11317:
URL: https://github.com/apache/ozone/pull/11317#discussion_r4095941305
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBCheckpointManager.java:
##########
@@ -117,6 +113,6 @@ public RocksDBCheckpoint createCheckpoint(String parentDir)
{
@Override
public void close() throws IOException {
- checkpoint.close();
+ // Checkpoints are created and closed per call, nothing to release here.
Review Comment:
kept `close()` as a no-op so the public `Closeable` API doesn't change.
Happy to drop it in a follow-up if we prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
