[ 
https://issues.apache.org/jira/browse/HDDS-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Doroszlai resolved HDDS-16565.
-------------------------------------
    Fix Version/s: 2.3.0
       Resolution: Done

> Per-volume replication @Config keys are not bound from ozone-site.xml
> ---------------------------------------------------------------------
>
>                 Key: HDDS-16565
>                 URL: https://issues.apache.org/jira/browse/HDDS-16565
>             Project: Apache Ozone
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.3.0
>
>
> h3. Problem
> Setting {{hdds.datanode.replication.per.volume.enabled=true}} in 
> ozone-site.xml does not enable per-volume push replication thread pools on 
> the DataNode. Configuration inspection shows the property, but 
> {{ReplicationConfig.isPerVolumeEnabled()}} remains {{false}} at runtime (see 
> {{ReplicationSupervisor}} init).
> h3. Root cause
> In {{ReplicationServer.ReplicationConfig}} (HDDS-15412), the per-volume 
> settings use {{@Config(key = PER_VOLUME_ENABLED_KEY)}} / {{@Config(key = 
> PER_VOLUME_STREAMS_LIMIT_KEY)}} where those constants expand to the full 
> property name. When configuration injection still prepends the 
> {{@ConfigGroup}} prefix ({{hdds.datanode.replication}}), the lookup key 
> becomes 
> {{hdds.datanode.replication.hdds.datanode.replication.per.volume.enabled}}, 
> so the user-facing property is never read.
> Other fields in the same class should use fully-qualified keys in 
> {{@Config(key = "...")}} per HDDS-14105 (same pattern as 
> {{hdds.datanode.replication.streams.limit}}).
> h3. Fix
> Use explicit fully-qualified {{@Config}} keys for per-volume enabled and 
> per-volume streams limit (keep {{PER_VOLUME_*_KEY}} constants for 
> tests/reconfiguration).
> h3. Related
> HDDS-15412



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to