elek commented on a change in pull request #2357:
URL: https://github.com/apache/ozone/pull/2357#discussion_r676373975
##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -528,6 +529,12 @@ enum StorageTypeProto {
RAM_DISK = 4;
}
+enum BucketTypeProto {
Review comment:
> Also, the plan is not to have both the `Map<String,String>` as well as
the enum together. The Map<String,String> will not be used once the enum has
been introduced.
I am against removing the `Map<String,String>` as it can be used not only
for storing bucket types but storing any other metadata. Also, it's an
incompatible change if we remove it.
And if we need to keep it: wouldn't it make more sense to use it to store
the bucket type (as we do it today?).
Again: I fully support to use bucket type as a concept: talk about multiple
bucket types, support bucket type argument in cli. I just try to understand the
arguments to introduce it a new protobuf level concept instead of using
existing metadata capabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
