chihsuan commented on code in PR #11295:
URL: https://github.com/apache/ozone/pull/11295#discussion_r4109757664
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestInterSCMGrpcProtocolService.java:
##########
@@ -110,6 +110,30 @@ void testMTLSOnInterScmGrpcProtocolServiceAccess() throws
Exception {
service.stop();
}
+ @Test
+ void testDownloadSucceedsWithCustomGrpcKeepAlive() throws Exception {
Review Comment:
nit: Just curious, is this test still needed? I noticed it passes with the
server keepalive lines removed, and the mTLS test above already covers a
similar download path. If we really want server coverage, the invalid-value
approach from `TestInterSCMGrpcClient` may work here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
