chihsuan commented on code in PR #11326:
URL: https://github.com/apache/ozone/pull/11326#discussion_r4110036332
##########
hadoop-ozone/dev-support/checks/junit.sh:
##########
@@ -28,6 +28,7 @@ cd "$DIR/../../.." || exit 1
: ${ITERATIONS:="1"}
: ${OZONE_WITH_COVERAGE:="false"}
: ${OZONE_REPO_CACHED:="false"}
+: ${PHASE:="test"}
Review Comment:
Just curious, is `unit.sh` meant to run only `test` too? I tested it locally
and found `ozonefs-hadoop2` fails to compile, since it doesn't pass
`-DskipShade`. The check still passed, silently skipping
`TestOmKeyInfoWithHadoop2`. Would keeping `verify` as the default here work, or
do you have another option in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
