devmadhuu commented on code in PR #11223: URL: https://github.com/apache/ozone/pull/11223#discussion_r4118849441
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ########## Review Comment: I was wondering if here a valid storagetype in blockId could slip in on mis-matched valid blockId's storageType and container's storageType. Could we validate the storage type here before opening the stream channel? Unlike the normal `WriteChunk` path, this path directly creates the channel without calling `BlockUtils.verifyStorageType().` For example, an SSD request for an existing DISK container would be accepted because SSD is valid, even though it does not match the container. If you think, it is being validated and caught anywhere else, please specify , if I am missing something here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
