ivandika3 commented on code in PR #11365:
URL: https://github.com/apache/ozone/pull/11365#discussion_r4180435926
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3SecretManager.java:
##########
@@ -102,6 +105,7 @@ default void updateCache(String accessId, S3SecretValue
secret) {
if (cache != null) {
LOG.info("Updating cache for accessId/user: {}.", accessId);
cache.put(accessId, secret);
+ TableCacheUpdateTracker.recordCacheUpdate(S3_SECRET_TABLE);
Review Comment:
The `S3SecretManager` uses table cache, but the implementation does not use
the unified `TypedTable`, probably because it supports both external S3 secret
store (i.e. `VaultSecretStore`) and embedded (OM RocksDB).
There is also cache related cleanup logic in `OzoneManagerDoubleBuffer` just
for `S3_SECRET_TABLE` which I think it kind of hacky since it has already been
supported by the OM `TableCache`. Technically, it should be possible to unify
it by making the `S3SecretCache` to be a `TableCache`, but this means that we
might need to make OM to generalize the table cache and store implementation
API (where the store can support other remote store like `VaultStore` or even
things like remote KV store), which is going to be quite involved.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/file/OMDirectoryCreateResponseWithFSO.java:
##########
@@ -71,7 +65,6 @@ public OMDirectoryCreateResponseWithFSO(@Nonnull OMResponse
omResponse,
public OMDirectoryCreateResponseWithFSO(@Nonnull OMResponse omResponse,
@Nonnull Result result) {
Review Comment:
Updated since there is also another review to address.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/snapshot/OMSnapshotPurgeResponse.java:
##########
@@ -30,21 +28,15 @@
import org.apache.hadoop.ozone.om.OmMetadataManagerImpl;
import org.apache.hadoop.ozone.om.OmSnapshotManager;
import org.apache.hadoop.ozone.om.helpers.SnapshotInfo;
-import org.apache.hadoop.ozone.om.response.CleanupTableInfo;
import org.apache.hadoop.ozone.om.response.OMClientResponse;
import org.apache.hadoop.ozone.om.snapshot.OmSnapshotLocalDataManager;
import
org.apache.hadoop.ozone.om.snapshot.OmSnapshotLocalDataManager.WritableOmSnapshotLocalDataProvider;
import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMResponse;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
* Response for OMSnapshotPurgeRequest.
*/
-@CleanupTableInfo(cleanupTables = {SNAPSHOT_INFO_TABLE})
public class OMSnapshotPurgeResponse extends OMClientResponse {
- private static final Logger LOG =
Review Comment:
Thanks, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
