chungen0126 commented on code in PR #11427:
URL: https://github.com/apache/ozone/pull/11427#discussion_r4210990104
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/LocalStream.java:
##########
@@ -60,7 +60,9 @@ public CompletableFuture<?> cleanUp() {
public CompletableFuture<ByteBuffer> onCommand(ByteBuffer buffer, long
streamOffset) {
return CompletableFuture.supplyAsync(() -> {
try {
- // TODO: drain datachannel.buffers
+ if (dataChannel instanceof KeyValueStreamDataChannel) {
+ ((KeyValueStreamDataChannel) dataChannel).drainBuffers();
+ }
Review Comment:
Should we proactively throw an exception here like cleanUp()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
